AnimaApp / Auto-Layout

Auto Layout for Sketch
https://animaapp.github.io/Auto-Layout
856 stars 40 forks source link

Exporting for Invision (with Craft) and Zeplin has critical problems #70

Closed delizade closed 6 years ago

delizade commented 6 years ago

Hello everyone,

First of all huge thank you for the grate plugin that changed my design workflow totally. In currently I had to use it for a huge project. But we've been struggling to solve exporting issues for Invision and especially Zeplin. Project has currently 30 pages and we are continuing to add new designs because of the weekly delivery deadlines.

When we tried to export, page layouts are being exported as broken/altered. Currently Anima App team is working for it we know and thanks for that but we thought that may be it was solved thanks to using some magical tricks :/ by other designers.

Do you have any solutions for that?

thank you.

orarbel commented 6 years ago

Hi @delizade, can you upload a Sketch file that has the issue?

Is it only in Stacks? or also pins?

orangefult commented 6 years ago

I'm experiencing this as well. I think it happens when more than on symbol at a time is detached. If you do it one at a time it seems to work alright.

So... although it will be a pain in the rear, you could manually go through and detatch all your symbols one at a time, then upload to Invision/Zepplin, and then use cmd-z like crazy.

This gif is me detatching symbols one at a time, you can see when I detach the stretched "ugly button" it kind of bounces back into place. one at a time symbol detatch

However, when I select all the symbols on the page and say "Detach from Symbol" they don't bounce back. all at once symbols detatch

avishic commented 6 years ago

Hey guys! Until we fix the multiple selection:

Select your artboards, use detach recursive, screenshot attached. It will detach everything in 1 action-> Single undo :)

screen shot 2018-03-11 at 9 09 08
delizade commented 6 years ago

Hi everyone, @orarbel Sorry because of our fully dedicated working days I couldnt share documents here. @orangefult thank you. unfortunately that way may work for small projects but we can not use it.

@avishic I think we tried it but not sure I will try it to see result to be clear. thank you so much.

I will tey to share as much as detailed cases. I hıpe we can solve this before development delivery. And we have a huge horror about that phase for now:/

avishic commented 6 years ago

@delizade @orangefult Until the official release here's the patch fix:

https://cl.ly/1O3K3q2e1C0q

delizade commented 6 years ago

Hi, Thank you for your efforts. I tested it new ver. but unfortunately it cant be done as recursively and same issues we have. I tried detach recursively

thank you again

detach Test-DetachSymbols.sketch.zip

avishic commented 6 years ago

Thanks @delizade ! We'll fix it too, the case here is that the stack is the only item in the symbol. Workaround: group the stack in the symbol (screenshot)

screen shot 2018-03-12 at 22 41 21
avishic commented 6 years ago

@delizade it went smoother then we thought, here's the patch fix: https://cl.ly/2B2q312U400z

We've also fixed "Prepare export for other plugins" option that broke on Sketch 49. Let us know all went smooth this time :)

delizade commented 6 years ago

Hi @avishic I can’t find a word for thank you. It seems okay now. I will be deep test later. Thank you so much!

chsWeb commented 6 years ago

I am still having major problems with this issue, however I am still on Sketch 48. Do we have to upgrade to Sketch 49 to get Auto Layout working as expected?

When trying detach symbols or "Prepare export to other plugins" that stacked groups break and resort all over the place. You can see the before and after attached - whether I chose to detach or prepare export, the same things break.

BEFORE:

autolayoutbyg-before

AFTER:

autolayoutbyg-after

delizade commented 6 years ago

Hi @avishic , I prepared a sample file to show one of my problems. It is similar problem with @chsWeb i think.

AutoLayout-Problem.sketch.zip source 1x result 1x

delizade commented 6 years ago

@chsWeb it seems that this issue may related to Auto Text fields. I tried Fixed rather than Auto and it prevent this problem.

orarbel commented 6 years ago

@delizade I've found something similar. Can you share more about your findings regarding the Fixed/Auto Text Layers issue?

delizade commented 6 years ago

Sadly we’ve decided to remove auto layout groups completly from about 90 arboards. It will take a huge time but after testing latest version of autolayout we experienced minor and major many problems when using detaching or “prepare for other plugins” to send to Zeplin.

chsWeb commented 6 years ago

@delizade same here, have abandoned Auto Layout and shifted to Paddy.

To speed the process up, you can use the Unstack Group Short cut and the Rename layer plugin to apply Paddy in Auto layout's place.

chsWeb commented 6 years ago

@delizade I found that if I was using Auto Layout Pinning, it was causing problems with Craft Sync. For example, if a I have a input, made of a text symbol and a shape symbol, where the text symbol was pinned to the left edge, when syncing to InVision, the text would be cropped.

Sketch is a bit painful without Auto Layout… I do hope you are able to sort these bugs out. I do understand that it is very complicated.

orarbel commented 6 years ago

We are releasing a version today that has critical fixes in the "Export to other plugins" feature.

Let us know if it works for you: https://cl.ly/081l2a3f0O1y/AnimaTookitPlugin.zip

(Restart Sketch after installing)

delizade commented 6 years ago

@chsWeb thank you for your suggestions I will look into it. @orarbel thank you as well when I find a time I will look new version and let you know result.

delizade commented 6 years ago

Hi @orarbel here is one of our artboard situation. We can't check all but I think sharing one of them better than nothing :) thank you.

original 2 result after prepare for other plugins Sketch file: https://www.dropbox.com/s/8bo2b61m5p1ssd0/test-08.sketch?dl=1

avishic commented 6 years ago

@delizade thanks for the file! With the latest beta it works for me :)

https://cl.ly/1m2R2v2i2X1w

Could you make sure all work well?

delizade commented 6 years ago

Hi everyone! this is a crazy news because I forgot to restart Sketch yesterday!

I did it now, I checked them and currently I want to cry, everything seems perfect!

So now, we will rearrange some artboards that we have removed plugin and we will send them to Zeplin.

@avishic thank you again!

chsWeb commented 6 years ago

I installed the latest version of the plugin and restarted Sketch, and I still have the same problems.

I am on macOS Sierra and Sketch 48.2 - does the new plugin fix only work in the latest macOS and latest Sketch, or should it also work in all supported versions of macOS/Sketch?

stigmates commented 6 years ago

Still critical issues. Can't use autolayout anymore. Too much time loose when exporting to zeplin.

SimonFricker commented 5 years ago

+1 this is still an issue