AnimaApp / Auto-Layout

Auto Layout for Sketch
https://animaapp.github.io/Auto-Layout
856 stars 40 forks source link

collapsing stacks + nested symbols + center doesn't work #77

Closed RaphyRaph closed 5 years ago

RaphyRaph commented 6 years ago

When collapsing a stack that contains symbols, the centering layout applied to the stack doesn't seem to work. In the screencap below, I would expect the stack to always be centered, regardless how how tall it is.

screencap: https://www.dropbox.com/s/u8qk2z48c2vefhx/stacking%20and%20centering.mov?dl=0

file: https://www.dropbox.com/s/dgg16t6jevgija9/stacking%20and%20centering.sketch?dl=0

delizade commented 6 years ago

hi @RaphyRaph

try to group "Stacked Group" in the symbol. I don't know why but grouping is working.

RaphyRaph commented 6 years ago

doesn't seem to work...

tmlarson commented 6 years ago

right there with you. pretty much everything with autolayout is full of bugs. takes forever to build one component that works momentarily, then you convert it to symbol and it doesnt work at all. literally every aspect of autolayout that used to work is falling apart. tried in both 47.1 and 49.1 with several versions of anima. groups, no groups, etc. I've found avoiding stacks altogether has benefits in that it wont destroy the rest of the pins. I love anima, just frustrated because a lot of work wrecked and hours gone down the drain. :/

delizade commented 6 years ago

@tmlarson @RaphyRaph it is solved thanks to 0.13.3 version. Thank you very much for that again! 👍 I hope one day we can export to Invision and Zeplin directly :)

tmlarson commented 6 years ago

I love it thanks guys.

Tyler

On Fri, Apr 6, 2018 at 8:22 AM delizade notifications@github.com wrote:

@tmlarson https://github.com/tmlarson @RaphyRaph https://github.com/RaphyRaph it is solved thanks to 0.13.3 version. Thank you very much for that again! 👍 I hope one day we can export to Invision and Zeplin directly :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AnimaApp/Auto-Layout/issues/77#issuecomment-379287380, or mute the thread https://github.com/notifications/unsubscribe-auth/AVRc1lFE1k28OwnlQj930D5L4BxqTBgWks5tl4hEgaJpZM4SsaxK .

nicolocampagna commented 6 years ago

Hi Guys,

I discovered to have this problem right now! :( Someone knows how to solve it?

Thanks in advance.

GravitaCo commented 6 years ago

This bug is not fixed, I have elements stacked horizontally and when I set the last components to none nothing collapses, this is becoming infuriating.

bazzle commented 5 years ago

Same problem. Seems to me like nested stacks just don't center pin.

SimonFricker commented 5 years ago

+1

avishic commented 5 years ago

We couldn't reproduce using the new Anima 3 Beta, after some stacks enhancements. Would you like to try it out and report if resolved? http://bit.ly/Anima3Beta

SimonFricker commented 5 years ago
screenshot 2019-01-24 at 15 36 57

thats a big version jump haha. I will give it a go.

bartberden commented 5 years ago

@avishic Still doesn't work properly on Anima 3. Removing the center pin solves the problem.

ehaft21 commented 5 years ago

Anima 3.1.7 this is not working. Symbol with stacked elements inside. Setting some elements within the stack to "none" causes stack to collapse properly, but its parent symbol does not center properly.

Note that the elements in my stack use anima padding. Could be related.

dlewand691 commented 5 years ago

This is still not working in 3.1.9.