fix check for scalePivotTranslate when enableReadAnimatedValues is changed - Githubissues

AnimalLogic / AL_USDMaya

This repo is no longer updated. Please see https://github.com/Autodesk/maya-usd

Other

266 stars 69 forks source link

fix check for scalePivotTranslate when enableReadAnimatedValues is changed #115

Closed pmolodo closed 5 years ago

pmolodo commented 6 years ago

Description (this won't be part of the changelog)

Fix for the setting of scalePivotTranslate in enableReadAnimatedValues - it was checking scalePivot instead of scalePivotTranslate.

Also, scalePivotTranslate / rotatePivotTranslate are vector values, not points. Also reverted a change to not use, ie, MVector::zero, per Rob's note here: https://github.com/AnimalLogic/AL_USDMaya/pull/112#pullrequestreview-152336003

Changelog

Fixed

check for whether scalePivotTranslate needs to be set enableReadAnimatedValues was checking if scalePivot was set, not scalePivotTranslate

Checklist (Please do not remove this line)

[X] Make sure the Title and Description of the PR make sense and provide sufficient context for your work
[X] Do any added files have the correct AL Apache Licence Header?
[X] Are there Doxygen comments in the headers?
[X] Are any new features, behaviour changes documented in the .md format documentation?
[ ] Have you added, updated tests to cover new features and behaviour changes?
[X] Have you filled out at least one changelog entry?