Closed sirpalee closed 5 years ago
Added a quick take on subclassing UsdImagingGLEngine as discussed in # 133. It's not tested, formatted or has its functions exported properly for now.
Updated formatting to match the rest of the codebase and ran some tests. Everything works as expected.
I'm not sure about the best place for "Engine", for now, I put it into the nodes subfolder since it's not really used anywhere else. Also, since it contains code copied directly from UsdImagingGL, should I add the Pixar copyright headers to Engine.cpp?
@sirpalee thanks for all of your hard work here, we're a bit tardy on approvals at the moment (I'm going to blame Australian summer holidays), we're waiting to have our own 19.01 build working internally to allow us to test this..
Thanks @sirpalee , just two things:
master
to develop
?
Once done, we are now ready to merge your work.@fabal Rebased! Now it should only contain changes that are required to make AL_USDMaya compatible with usd-0.19.1.
Awesome, thanks.
Cleaned up the commit history a bit and rebased, if you haven't already merged this...
Thanks @elrond79, we will be merging this shortly.
Description (this won't be part of the changelog)
The following PR updates the plugin to work with the latest changes found on the dev branch. The changes won't build, because of UsdImagingGLEngine::TestIntersectionBatch was removed, without any alternative. For now, I left that piece of code unchanged.
Changelog
Added
Added support for 0.19.1 version of USD.
Changed
Deprecated
Removed
Removed support for 0.18.11 version of USD.
Fixed
Checklist (Please do not remove this line)