We were getting "double delete crashes" in the import_instances test
Changelog
Added
We changed the argument of the std::set erase method to be the Key that the iterator points to (instead of the iterator itself). The erase method also accept as argument the key of the element you want to remove. This change fixed the crash for us
Changed
Deprecated
Removed
Fixed
Checklist (Please do not remove this line)
[x] Make sure the Title and Description of the PR make sense and provide sufficient context for your work
[ ] Do any added files have the correct AL Apache Licence Header?
[ ] Are there Doxygen comments in the headers?
[ ] Are any new features, behaviour changes documented in the .md format documentation?
[ ] Have you added, updated tests to cover new features and behaviour changes?
[x] Have you filled out at least one changelog entry?
[x] Is the branch's history clean? (only relevant commits)
Description (this won't be part of the changelog)
We were getting "double delete crashes" in the import_instances test
Changelog
Added
We changed the argument of the std::set erase method to be the Key that the iterator points to (instead of the iterator itself). The erase method also accept as argument the key of the element you want to remove. This change fixed the crash for us
Changed
Deprecated
Removed
Fixed
Checklist (Please do not remove this line)