Mostly a code organization change, though it does prevent m_params.showGuides from being updated twice in ProxyDrawOverride::prepareForDraw (once by ProxyShape::getRenderAttris, and once in the function body).
Was motivated by some internal tweaks of mine, that needed to call getRenderAttris, but organizationally it makes sense that if we're updating showGuides, we should update showRender too.
Changelog
Changed
make getRenderAttris update showRender, as well as showGuides
Checklist (Please do not remove this line)
[X] Make sure the Title and Description of the PR make sense and provide sufficient context for your work
[X] Do any added files have the correct AL Apache Licence Header?
[X] Are there Doxygen comments in the headers?
[X] Are any new features, behaviour changes documented in the .md format documentation?
[x] Have you added, updated tests to cover new features and behaviour changes?
[X] Have you filled out at least one changelog entry?
Description (this won't be part of the changelog)
Mostly a code organization change, though it does prevent
m_params.showGuidesfrom being updated twice inProxyDrawOverride::prepareForDraw(once byProxyShape::getRenderAttris, and once in the function body).Was motivated by some internal tweaks of mine, that needed to call
getRenderAttris, but organizationally it makes sense that if we're updating showGuides, we should update showRender too.Changelog
Changed
Checklist (Please do not remove this line)