search

Animated-Java / animated-java

A Blockbench plugin that makes complex animation a breeze in Minecraft: Java Edition.
Other
156 stars 25 forks source link

[BUG] Incorrect Default Values Pertaining Easing Functions #216

Closed learliet closed 1 month ago

learliet commented 1 month ago

The default values for Bounciness, Elasticity, and Overshoot can be incorrect in certain cases. For instance, when selecting Bounce before switching to Elastic, the Elasticity property does not default to 1 but retains the value of 0.25 (which is the default for Bounciness).

SnaveSutit commented 1 month ago

This is because when you select an easing mode with arguments, at first it has no value, so it's set to the default, but when switching, the value already exists, so it doesn't overwrite it with the default.

Do you think it should overwrite the value the user has chosen with the default when changing the easing mode?

learliet commented 1 month ago

Yeah, I'd say so. It feels more intuitive, especially since I can't think of a situation where maintaining the value would be more useful. Bounciness, Elasticity, and Overshoot are distinct effects, so using the default setting makes more sense imo.