Animated-Java / animated-java

A Blockbench plugin that makes complex animation a breeze in Minecraft: Java Edition.
Other
156 stars 25 forks source link

[BUG] Bone Configs Not Functioning Correctly #222

Open learliet opened 1 month ago

learliet commented 1 month ago

Bone configs are not truly independent. Changing the configuration of one bone inadvertently affects the configuration of other bones. Additionally, when creating a new bone, it starts with the configuration of the last modified bone instead of the default bone configuration.

display_settings_bug

SnaveSutit commented 1 month ago

Hmm this looks like an issue with the system for bone config inheritance.

SnaveSutit commented 1 month ago

I've fixed the main issue here, which was it was passing around the same object as the config instead of cloning it. However the inheritance is still a little funky, as it's a custom system and it's a more difficult problem than I though it would be.