search

Animated-Java / animated-java

A Blockbench plugin that makes complex animation a breeze in Minecraft: Java Edition.
Other
165 stars 27 forks source link

🐛 Fix "Skipping entity with id" Minecraft log spam #316

Closed TheAfroOfDoom closed 1 month ago

TheAfroOfDoom commented 2 months ago

anytime you summon an entity with locators (or other non-bone/display types), the game logged a warning: "Skipping entity with id". this warning spams the log very quickly when many AJ models are summoned in-game

the switch block that generates the root entity's passengers was adding a passenger entity for each node in the rig. not all nodes are actually a passenger of the root entity though.

these nodes were still being added to the passenger list with only a Tags:["aj.rig_entity"] field. Minecraft sees this entity and skips it because it has no specified id

(the warning in-game should say "Skipping entity without id" instead)

before after
image image
SnaveSutit commented 1 month ago

I had to implement this change manually because of a recent major overhaul of the data pack compiler, but this is now fixed.