Scene Tag Support! - Githubissues

Anime-Game-Servers / Grasscutter-Quests

A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.

https://grasscutters.xyz/grasscutter

GNU Affero General Public License v3.0

133 stars 31 forks source link

Scene Tag Support! #119

Closed scooterboo closed 7 months ago

scooterboo commented 7 months ago

Added ExecAddSceneTag and ExecDelSceneTag. Cleaned up PacketPlayerWorldSceneInfoListNotify

Minor bug: ~seems you need to relog or do /tp ~ ~ ~ to get the scene to refresh.~

Description

Type of changes

[x] Bug fix
[x] New feature
[x] Enhancement
[ ] Documentation

Checklist:

[x] My code follows the style guidelines of this project
[x] My pull request is unique and no other pull requests have been opened for these changes
[x] I have read the Contributing note and Code of conduct
[x] I am responsible for any copyright issues with my code if it occurs in the future.

StartForKiller commented 7 months ago

@Hartie95 I think this can be merged

Hartie95 commented 7 months ago

@Hartie95 I think this can be merged

We had some internal talk with Nazrin, and it might be better to store some state with them, so that we can have the states Enabled/Disabled/default, to differentiate between directly set tags and defaults based on conditions/excels.

Also since there are more ways to set them, it might be good to have a setter for them that triggers the notify required.

There is also the SceneDataNotify (since 2.8) packet and PlayerEnterSceneNotiry (since 1.1), that also include scene tags.

I also added the packet to multiproto, so it would be nice to use it for that packet.

scooterboo commented 7 months ago

71bdfd7c4be6b713e28c6e9f08067a58ba987fdc fixes a bug: you no longer fall through the jade palace!

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud