A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.
Was trying to trigger Boreas, but ran into problems with his pre-battle timer not being created. (group 133002259).
There's some more traditional pyro monuments close by with the same issue (group 133002344)
The old code has several flaws:
If the EVENT_TIMER_EVENT has source = "", the timer never gets created.
If multiple EVENT_TIMER_EVENT match the source (like if you made the code check if trigger.getSource().equals("")), the timer is canceled and created over and over on each iteration that matches. Only the last timer remains.
All of it doesn't matter anyway since the callEvent in realCallEvent (line 725 or so) is going to handle the EVENT_TIMER_EVENT for every timer trigger where the source matches the source or the source is "".
Iteration and source checking does not make sense here. You don't need to manually check the source (the source is checked later), you don't need to make the timer multiple times (it's run multiple times later).
Type of changes
[x] Bug fix
[ ] New feature
[ ] Enhancement
[ ] Documentation
Checklist:
[x] My code follows the style guidelines of this project
[x] My pull request is unique and no other pull requests have been opened for these changes
Description
Was trying to trigger Boreas, but ran into problems with his pre-battle timer not being created. (group 133002259).
There's some more traditional pyro monuments close by with the same issue (group 133002344)
The old code has several flaws:
Iteration and source checking does not make sense here. You don't need to manually check the source (the source is checked later), you don't need to make the timer multiple times (it's run multiple times later).
Type of changes
Checklist: