Closed scooterboo closed 2 months ago
Notable things:
PacketDungeonSettleNotify is converting from an old style DungeonSettleNotify to a new one. BaseDungeonResult will need a major rewrite soon.
PacketWorldPlayerDieNotify assumes the killerId is a monster. I've left it as-is
PacketAvatarExpeditionAllDataRsp is hardcoding values from ExpeditionDataExcelConfigData
Issues 1 New issue 0 Accepted issues
Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code
See analysis details on SonarCloud
Notable things:
PacketDungeonSettleNotify is converting from an old style DungeonSettleNotify to a new one. BaseDungeonResult will need a major rewrite soon.
PacketWorldPlayerDieNotify assumes the killerId is a monster. I've left it as-is
PacketAvatarExpeditionAllDataRsp is hardcoding values from ExpeditionDataExcelConfigData
Type of changes
Checklist: