Anime-Game-Servers / Grasscutter-Quests

A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.
https://grasscutters.xyz/grasscutter
GNU Affero General Public License v3.0
133 stars 31 forks source link

Packet Pack: Act 1, Dungeons, Expeditions, Fetters #136

Closed scooterboo closed 2 months ago

scooterboo commented 2 months ago

Notable things:

PacketDungeonSettleNotify is converting from an old style DungeonSettleNotify to a new one. BaseDungeonResult will need a major rewrite soon.

PacketWorldPlayerDieNotify assumes the killerId is a monster. I've left it as-is

PacketAvatarExpeditionAllDataRsp is hardcoding values from ExpeditionDataExcelConfigData

Type of changes

Checklist:

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud