Refactored BaseDungeonResult + GameItem.toItemParam is amazing

Anime-Game-Servers / Grasscutter-Quests

A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.

https://grasscutters.xyz/grasscutter

GNU Affero General Public License v3.0

138 stars 31 forks source link

Refactored BaseDungeonResult + GameItem.toItemParam is amazing #141

Closed scooterboo closed 3 months ago

scooterboo commented 3 months ago

Refactored BaseDungeonResult, got rid of associated OuterClasses, and learned of GameItem.toItemParam

Type of changes

[ ] Bug fix
[ ] New feature
[x] Enhancement
[x] Documentation

Checklist:

[x] My code follows the style guidelines of this project
[x] My pull request is unique and no other pull requests have been opened for these changes
[x] I have read the Contributing note and Code of conduct
[x] I am responsible for any copyright issues with my code if it occurs in the future.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud