Open scooterboo opened 2 months ago
Sometimes, dungeon entries are listed twice like this dungeon 1117, scene point 291:
It seems that in DungeonEntryManager.getDungeonEntries, this dungeon is both a basicDungeon and a plotDungeon:
It's a plot dungeon because there is a quest for it (Quest 200703):
It's a basicDungeon because it's here in scene3_point.json:
At the bottom of that scene point entry, I notice it has "unlocked" set to false:
I'm guessing we should filter for that:
If we do, it goes away:
Does this look about right? Want a PR for it?
Which branch did you use?
refactoring_multiproto_0.2 Grasscutter version: 1.4.4-dev-89a3a350 Git Hash: 89a3a3506629556befbebb989380b3f8f2d0d998 (it's local)
Sometimes, dungeon entries are listed twice like this dungeon 1117, scene point 291:
It seems that in DungeonEntryManager.getDungeonEntries, this dungeon is both a basicDungeon and a plotDungeon:
It's a plot dungeon because there is a quest for it (Quest 200703):
It's a basicDungeon because it's here in scene3_point.json:
At the bottom of that scene point entry, I notice it has "unlocked" set to false:
I'm guessing we should filter for that:
If we do, it goes away:
Does this look about right? Want a PR for it?
Which branch did you use?
refactoring_multiproto_0.2 Grasscutter version: 1.4.4-dev-89a3a350 Git Hash: 89a3a3506629556befbebb989380b3f8f2d0d998 (it's local)