Anime-Game-Servers / Grasscutter-Quests

A server software implementation, ineroperable with a certain anime game client. The code in this repository is fully custom made for edyoucational purposes and future preservation, no copyrighted code is allowed in this repository.
https://grasscutters.xyz/grasscutter
GNU Affero General Public License v3.0
133 stars 31 forks source link

[Bug] Light actuators can only be picked up once per login #99

Open scooterboo opened 8 months ago

scooterboo commented 8 months ago

Describe the bug In Light Guiding Ceremony the light actuators only let you interact with them once per account login. If you are over your limit, they disappear. They thankfully reappear when you log in again.

How to replicate: Run into more than one light actuator. It's not hard

Notes: Light actuator groups are 133007228, 133007229 and 133007230 Light actuators are gadget 70950006 serverController: Test_LightLock_Point

Which branch did you use? multi_proto Grasscutter version: 1.4.4-dev-f1cdbc02 Lua: JNLua

Screenshots

https://github.com/Anime-Game-Servers/Grasscutter-Quests/assets/1877986/02f1e8fd-7115-467d-a1e1-ef07b643b151

scooterboo commented 7 months ago

See also https://github.com/Anime-Game-Servers/Grasscutter-Quests/issues/118

StartForKiller commented 2 months ago

Caused by trigger deregister, Solution 1: Don't deregister when an action return -1. Solution 2: Make impossible to call a trigger when that event that caused the trigger will call the same function