search

Anime-Lists / anime-lists

115 stars 52 forks source link

Update README with notes about one-to-many and many-to-one mappings #341

Closed winterbird-code closed 1 year ago

winterbird-code commented 1 year ago

This fixes #339.

In addition to the readme, I also updated the episode mapping for Ling Qi, for which AniDb has half-lenght episodes and TVDB has full-lenght episodes.

AniDB TVDB/TMDB/IMDB Notes
https://anidb.net/anime/12656 https://thetvdb.com/index.php?tab=series&id=321503 Season 1
BrutuZ commented 1 year ago

"One to many" can be misleading, only one to two is supported. ;1-1+2; Works ;1-1+2+3; Doesn't

winterbird-code commented 1 year ago

Oh, I didn't know that.... How definite is that restriction? For example the Burn the Witch movie is three episodes in TVDB, so to create a proper mapping for that there is a need for a one-to-more-than-two mapping.

If it's not feasible to change I will update this PR to reflect that restriction, but we probably need to think about how to handle Burn the Witch and other cases like it (I'm pretty sure I had at least one more example, but I can't remember it right now).

BrutuZ commented 1 year ago

Not really a list restriction per-se, it's a client one, ASS specifically. It will only merge 2 episodes. Learned it the hard way after trying to map a single episode to 72 parts

winterbird-code commented 1 year ago

Ah, OK. Since it wasn't documented before I suppose each client did their own interpretation.

If we only allow one-to-two mappings no client will ever be able to handle these episodes, but if we allow one-to-many at least we give the clients the information they need to do a proper mapping. If they do not implement one-to-many for whatever reason they will not be able to map these few specific episodes, but I don't think it would break anything that wasn't already broken.

So if we want to be able to do proper mappings I still think we should support one-to-many mappings in the lists.

winterbird-code commented 1 year ago

I moved the Ling Qi update to #343 to keep this about the README update.