search

Anime-Lists / anime-lists

109 stars 52 forks source link

attack on titan movies #41

Closed fawzib closed 3 years ago

fawzib commented 3 years ago

https://anidb.net/anime/10583

should map to:

https://thetvdb.com/movies/attack-on-titan-crimson-bow-and-arrow https://thetvdb.com/movies/attack-on-titan-the-wings-of-freedom

sven-7 commented 3 years ago

@reconman I don't think we map to TheTVDB movies. Right? This is mapped to the correct specials already.

fawzib commented 3 years ago

movies should not be in specials otherwise the normal plex scrapper will be fine.

reconman commented 3 years ago

So far, no entry is mapped to a TVDB movie. In fact, many entries have tvdbid="movie" set to indicate that there will never be a TVDB entry.

I saw some message by a TVDB admin that movies should not be specials, but people still do it.

I can't tell how Hama will react to linking to a movie, especially if your episode is already using the S00E file name format. I don't want to break existing logic.

Will have to experiment to find out.

fawzib commented 3 years ago

so what is the logic behind not mapping a movie to tvdbid?

reconman commented 3 years ago

You'd have to ask Scudlee, who disappeared into thin air.

The main question is: Why do you want to link to the TVDB movie entries?

sven-7 commented 3 years ago

I'm also not sure if @zeroqi's HAMA and ASS would break if we did that.

fawzib commented 3 years ago

in the example above we have 3 attack on titan movies. 2 are in one anidb and the other is separate. all are compilations for example.

another example is Re: zero we have 2 special series with multiple seasons merged into one anidb (11370) Re:Petit - Re: Starting Life in Another World from Petit Re:Zero - Starting Break Time from Zero

each should map to a different tvdb series.

we should start mapping movies to tvdb and not to specials. keep the series clean, this is why we have collections

ZeroQI commented 3 years ago

ScudLee created the anidb.net agent for XBMC and the XML for mapping episode summaries from TheTVDB if i recalled well

we should start mapping movies to tvdb and not to specials. keep the series clean, this is why we have collections

  • We do have collections, and also collection field auto creation for grouping folders with "local" metadata source for 'collection' HAMA setting (quite like the simplicity), or the movie collection increased with anidb related anime...
  • A movie should not be mapped to TheTVDB specials according to theTVDB rules and knowing they support movies now, it makes sense
  • Movie will be mapped to TheTVDB but doesn't mean HAMA or even Anime-Lists has to support it, as HAMA code is already complex. It does support TheMovieDb movies [tmdb-xxxx] and TheMovieDb series [tsdb-xxxx] already, so why reinvent the wheel? HAMA am not going to support Th

This should be a pure AniDB entry for HAMA: Gekijouban Shingeki no Kyojin [anidb-10583]/s01e01-02

This should be a pure AniDB entry for HAMA: Re:Zero - Starting Life in Another World [anidb-11370] s00e02-26

If you want to keep the series clean, don't download chibi short for the series maybe? You want to map every single anime movie to thetvdb movie when HAMA has no support coded for V3 API? In theory, we could have another mapping file from anidb to thetvdb movie, but why should we? Which tvdb or anidb numbering to use? HAMA does anidb by default so it would gather metadata, so why double the complexity for Movies?