BrutuZ
commented
9 months ago Why replace the absolute mappings with 1?
Closed winterbird-code closed 9 months ago
BrutuZ
commented
9 months ago Why replace the absolute mappings with 1?
winterbird-code
commented
9 months ago For me it's mostly because of this issue with jellyfin-tvdb-plugin which in turn forces me to handle absolute-ordered series separately in my jellyfin-anime-sync-utility. TL;DR is that if you configure jellyfin to use absolute numbering for a tv-series any special-episode for that series will get the wrong metadata.
As long as I can map every episode to a season this is not a problem, which is the reason I try to add seasons to series that are absolute ordered in the list.
When the series has multiple seasons it makes somewhat sense to have both defaulttvdbseason="a" and explicit season mapping and let the user implementation decide how to handle it, but for series with just one season with the same episode order as "absolute ordering" I think it's unnecessary.
I don't really see any case where this change would break anything, but if it feels better I can add explicit season mapping for these series instead.
BrutuZ
commented
9 months ago I was just trying to understand the reasoning behind it, thanks for explaining. It won't break anything in these instances, it'll just be a bother if the TVDB mods decide to split it into arc-based seasons. Cross that bridge if/when it comes
So Juuni Kokui and the original Shaman King is currently set to absolute order, despite only having one season in TVDB (in which the episode order is the same as in the absolute order). This PR re-maps those series to season 1 instead which is more consistent with other one-season-series. The alternative is to keep absolute order, but also add an explicit mapping for all episodes to season 1, which seems a bit unnecessary.