search

AnimeNeko / Atarashii

DISCONTINUED. Atarashii! - An amazing, modern MAL app for Android 4+
http://atarashiiapp.com
BSD 2-Clause "Simplified" License
79 stars 23 forks source link

Search/Add Support #10

Closed AnimaSA closed 11 years ago

AnimaSA commented 12 years ago

I'm really bad at writing summaries, so I'll keep it short. The gist of this would be:

 -Possibly a search action view thing in the ActionBar, the expandable one
 -New search results
 -New menu xml with basically just a "Add to List" button to be used in the DetailView if the record isn't on a list
 -And of course, the backing code to make this work.

Hopefully some of the existing net code in place can be reused to leverage MAL's search api.

srvrguy commented 12 years ago

I'd start with a simple "add" button on the action bar inside the anime/manga lists that search for those specific media types. That would lead to the search interface. This could later be extended into a fancier search tool.

Potentially instead of having an "add to list" option in the detail view it could be done in the action bar? This would avoid having to mess too much with the detail view itself.

AnimaSA commented 12 years ago

Should've been more clear, the new menu xml would be the action bar button.

In my opinion though, it would be easier to make a unified site/local search right from the beginning rather than make a local search and then extend it to also search the site. I'm actually thinking of using the tabbed layout again, on one side would be "Local", the other side "Online". The local search fragment would just search the database while the online fragment does the network operation and returns a list provided by the api. This approach also has the benefit of the code being fragments, so they could be reused in a different manner, perhaps side by side for tablets.

Well, not that search will probably make it into the 1.1 release. I'll work on it in a separate branch. 1.1 will probably be the manga support, and I also want to throw in the "+1 Watched" button back in. It's been requested a few times, and basic idea has been the same: put a +1 button on the covers in the grid view. Shouldn't be terribly hard, but I'll also open a separate branch for that.

srvrguy commented 12 years ago

I suppose it makes sense that way. If you feel it would work best, then I respect your opinion on that.

For a "+1" increment quick action, what about using a spinner on the overlay area of the cover grid? You can also add other common actions such as "Mark Complete" in there as well. This would be similar to how the Play Music application handles common actions in its list view.

AnimaSA commented 12 years ago

Ah, that's actually really clever! Now to go look for resources how to do that.

edit: Wait. Those aren't spinners in the Play Music app, they're PopUp Menus,. Similar to spinners, but no persistent selection. Shouldn't be too hard.

AnimaSA commented 12 years ago

Well for now, I pushed a new branch "plusonecovers", which I named before you mentioned doing the more actions thing. The only change at the moment is the inclusion of a overflow button nestled in the bottom left of each cover. Clicking the button doesn't do anything yet, but /will/ open up a popup menu with the actions you can take.

srvrguy commented 11 years ago

Assigning to self to handle integrating search support from Daniel Brierton

Apkawa commented 11 years ago

Implemented basic feature a search https://github.com/AnimaSA/DreadfulMALX/pull/43

srvrguy commented 11 years ago

The previous pull requests by Apkawa have provided the basic functionality of this issue, so I'm going to close it.