search

AnimeNeko / Atarashii

DISCONTINUED. Atarashii! - An amazing, modern MAL app for Android 4+
http://atarashiiapp.com
BSD 2-Clause "Simplified" License
79 stars 23 forks source link

Tags not supported #492

Closed Nomeji closed 8 years ago

Nomeji commented 8 years ago

Tags appear in interface but aren't supported. How to reproduce: Select anime with tags, go to personal, tags is empty. or Select anime, go to personal, add tags, return, reselect same anime, tags is empty.

ratan12 commented 8 years ago

Which website are you using? I will look into this issue.

Nomeji commented 8 years ago

I experiment this issue on MAL.

On Oct 10, 2016 12:08, "ratan12" notifications@github.com wrote:

Which website are you using? I will look into this issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AnimeNeko/Atarashii/issues/492#issuecomment-252578509, or mute the thread https://github.com/notifications/unsubscribe-auth/AFkZCsFmcz4GIOzoIL6_Ey2Hx9jSo_SBks5qyg6ygaJpZM4KSXUW .

ratan12 commented 8 years ago

I can reproduce it but the funny thing is that I do not see any update command in the log. It looks like the app does not call the write task.

ratan12 commented 8 years ago

It looks like after the dirty rewrite the Personal tags was never added as dirty field. We use a dirty field to determine if we should update a record if the user will press back.

It was never added thus never updated and saved.

Commit 034d57a fixed it.

Thanks for reporting!

Nomeji commented 8 years ago

Thanks a lot for fixing this! I'm not sure that updating the tag when modifying is the only problem tho. As I said, tags aren't showing even if they are added through the official website. I detail it better: How to reproduce: Add personal tags to an anime with MyAnimeList website. Go to Atarashii on your phone. Select the same anime, go to personal, tags is empty.

ratan12 commented 8 years ago

Did I just seriously fixed an unknown bug by misunderstanding. I just tried what you said using the official website and the app is not syncing it.

Update: Apparently there was a code missing in the API models. Why? I have honestly no idea but it has been fixed now so you can update and read the personal tags in the next minor version. Commit f8f6fb3

Nomeji commented 8 years ago

Ah ah I found two separate bugs in row without even noticing! Great job, thanks!

On Oct 15, 2016 16:33, "ratan12" notifications@github.com wrote:

Did I just seriously fixed an unknown bug by misunderstanding. I just tried what you said using the official website and the app is not syncing it.

Update: Apparently there was a code missing in the API models. Why? I have honestly no idea but it has been fixed now so you can update and read the personal tags in the next minor version. Commit f8f6fb3 https://github.com/AnimeNeko/Atarashii/commit/f8f6fb36b7ea4f883e7d1fcf5664e39a5ac77ef9

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AnimeNeko/Atarashii/issues/492#issuecomment-253987772, or mute the thread https://github.com/notifications/unsubscribe-auth/AFkZCoknAQQU8mJCEQsywpB9ZnyKjLMdks5q0OQggaJpZM4KSXUW .