search

AnimeshSinha1309 / algorithms-notebook

The team notebook to keep all template code and notes in.
23 stars 5 forks source link

Updates to Continuous Integration Config #2

Closed GaurangTandon closed 4 years ago

GaurangTandon commented 4 years ago

Oj version is now 9.x Remove clang Update to ubuntu 18.04

AnimeshSinha1309 commented 4 years ago

Wait, do not merge. Why are you removing compilation via clang?

GaurangTandon commented 4 years ago

I do not see any reason to run the same tests for executables from two different compilers. Can you please justify why both gcc executables and clang executables need to be generated?

AnimeshSinha1309 commented 4 years ago

Just for safety, sometimes there is undefined behavior, lots of it, in C++, and we GCC still manages to make it work, but CLang does not. Having the code tested on both gives us virtual immunity against any issues with the C++ standard, and we have to pay no price for it.

GaurangTandon commented 4 years ago

Alright, you may please re-add clang as a compiler and merge this branch. Thanks.