search

Animeshz / site

(Home | Blog | Notes | Projects | Reflect Back)
https://animeshz.github.io/site/
Creative Commons Attribution 4.0 International
8 stars 3 forks source link

updated vitepress to latest version #16

Closed pritamgupta-07 closed 1 year ago

pritamgupta-07 commented 1 year ago

updated vitepress to latest version ^1.0.0-rc.20 #11

Animeshz commented 1 year ago

Have you verified the changes? It doesn't look like pnpm-lock.yaml file has been updated. Can you please execute pnpm i push the commit?

pritamgupta-07 commented 1 year ago

Sorry, I don't have much idea about YAML files. Can you guide me? Actually i am new to this.

Animeshz commented 1 year ago

Lock files don't have to be touched by hand, just run pnpm i, it'll update by itself :)

pritamgupta-07 commented 1 year ago

i meshed up while installing pnpm on my machine.

pritamgupta-07 commented 1 year ago

i think everything is okay this time.

Animeshz commented 1 year ago

Last commit is again incompatible with lock file (you changed the package.json without running pnpm i). Please run pnpm i and push again. This will be the last nitpick before merging.

Next to it, everything else LGTM :tada:, thanks for your contribution!

pritamgupta-07 commented 1 year ago

So i need to run pnpm i everytime when ever package.json file is changes. thanks for the guidance.