v1.0.0 to v1.1.0 error log

[Anirban166]

A list of errors I faced and resolved during the transition:

• Apparently, runs-on has to be specified within the calling workflow and thus the container I'm using too has to be an external specification:

  Error: Anirban166/Autocomment-atime-results/v1.0.0/action.yml (Line: 10, Col: 3): Unexpected value 'container'

• Mentioning the shell property (bash in my case) is required: (didn't have to for the standalone version of my workflow)

  Error: Anirban166/Autocomment-atime-results/v1.0.1/action.yml (Line: 16, Col: 7): Required property is missing: shell

• secrets is only recognized within the calling workflow's scope, thus my entire workflow here has to be run in that environment with the caller's GITHUB_PAT appropriately set:

  Error: Anirban166/Autocomment-atime-results/v1.0.1/action.yml (Line: 20, Col: 21): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN

• Likewise, repo_token too must be specified externally: (for cml ops)

  Run echo "![Comparison Plot](./inst/atime/tests_all_facet.png)" >> report.md
  echo "![Comparison Plot](./inst/atime/tests_all_facet.png)" >> report.md
  echo "\nGenerated via commit b374db0c373b4277b69d472c075ce16a8e17f710" >> report.md
  echo "\nDownload link for the artifact containing the test results: [↓ atime-results.zip](https://github.com/Anirban166/data.table/actions/runs/8260654275/artifacts/1321342849)" >> report.md
  echo "\nTime taken to install \`atime\` and run \`atime_pkg\` on the test(s): $((ATIME_STEP_RUNTIME%3600/60)) minutes and $((ATIME_STEP_RUNTIME%60)) seconds" >> report.md
  cml comment update report.md
  shell: bash --noprofile --norc -e -o pipefail {0}
  env:
  GITHUB_PAT: ***
  R_KEEP_PKG_SOURCE: yes
  R_LIBS_USER: /__w/_temp/Library
  TZ: UTC
  _R_CHECK_SYSTEM_CLOCK_: FALSE
  NOT_CRAN: true
  RSPM: https://packagemanager.posit.co/cran/__linux__/focal/latest
  RENV_CONFIG_REPOS_OVERRIDE: https://packagemanager.posit.co/cran/__linux__/focal/latest
  ATIME_STEP_RUNTIME: 281
  {"level":"error","message":"token not found","stack":"Error: token not found\n    at new Github (/usr/lib/node_modules/@dvcorg/cml/src/drivers/github.js:91:23)\n    at CML.getDriver (/usr/lib/node_modules/@dvcorg/cml/src/cml.js:161:35)\n    at CML.commentCreate (/usr/lib/node_modules/@dvcorg/cml/src/cml.js:184:22)\n    at exports.handler (/usr/lib/node_modules/@dvcorg/cml/bin/cml/comment/create.js:11:25)\n    at Object.exports.handler (/usr/lib/node_modules/@dvcorg/cml/bin/cml/comment/update.js:10:9)\n    at /usr/lib/node_modules/@dvcorg/cml/node_modules/yargs/build/index.cjs:1:8993\n    at /usr/lib/node_modules/@dvcorg/cml/node_modules/yargs/build/index.cjs:1:4949"}
  Error: Process completed with exit code 1.

• \n doesn't seem to get escaped (needs the -e flag) for the bash shell used by the runner:

  

• Safe directory checks are a must: (got them disabled completely or was able to mark every directory as safe this time)

  Run git switch "${GITHUB_BASE_REF}"
  fatal: detected dubious ownership in repository at '/__w/data.table/data.table'
  To add an exception for this directory, call:
  
  git config --global --add safe.directory /__w/data.table/data.table
  Error: Process completed with exit code 128.