Anirban166 / data.table.threads

Other
2 stars 1 forks source link

please delete geom_rect #15

Closed tdhock closed 2 months ago

tdhock commented 2 months ago

as I see it, the geom_rect is drawn from y=0 to y=ideal/red dot, right? in that case it does not add any information, beyond what we can already see in the red dot, so please delete (redundantly displayed info is potentially confusing)

image

tdhock commented 2 months ago

@Anirban166

Anirban166 commented 2 months ago

as I see it, the geom_rect is drawn from y=0 to y=ideal/red dot, right?

It actually comes from this geometry: https://github.com/Anirban166/data.table.threads/blob/69d3571495b65f31949d0f12f9f8a329be860894/R/plot.data_table_threads_benchmark.R#L57

in that case it does not add any information, beyond what we can already see in the red dot, so please delete (redundantly displayed info is potentially confusing)

I agree, removing it in a minute