search

AnirbanBanik1998 / Modern_Speak_and_Spell

GSoC 2018 project
MIT License
7 stars 4 forks source link

Confusion in the `Recorder` class #3

Closed zeekhuge closed 6 years ago

zeekhuge commented 6 years ago

The Recorder class in the API has 2 different self.start being used.

The 1st one is a method while the other one is a variable.

This will basically result in hiding one of them by other, based on which statement gets executed later. Also, this creates confusion while understanding what you really are trying to do there. Also, is the self.start variable really needed to be in the self object ? ? Looks like its local to the record() hence, you might just be able to use a local variable. But, cant be sure as the code is a bit confusing as of now.

AnirbanBanik1998 commented 6 years ago

Yeah you're right...I modified my code...renaming some variables which can be kept local...didn't notice it earlier...Thanks for your suggestion

AnirbanBanik1998 commented 6 years ago

I guess this issue is also resolved...so closing it.