AnishShr / autoware_mini_practice

Practice Sessions and Labs for the Autonomous Vehicles Project (Autoware mini)
MIT License
0 stars 0 forks source link

Practice 2 #1

Closed geopimik closed 6 months ago

geopimik commented 6 months ago

Please correct the following:

  1. Remove printouts from the final node! They are suitable for debugging, but it clutters the console output when the node is finished.
  2. I would suggest creating messages in the callback! Feels safer. You overwrite the values in the callback, but if something goes wrong and they are not overwritten, then old values will be published, and it might be hard to notice that something is wrong.
  3. Azimuth correction needs to be subtracted!
AnishShr commented 6 months ago
  1. Removed printouts from the node
  2. Created messages inside the callback function
  3. Azimuth correction subtraced
AnishShr commented 6 months ago

https://github.com/AnishShr/autoware_mini_practice/commit/b1fd3054a5348d5b3fc7bd6b7de886311d59defa