Closed geopimik closed 4 months ago
There should be enough of having these: https://github.com/AnishShr/autoware_mini_practice/blob/21d92c582d289c5f9fc24b477ca34f7889b10b66/practice_6/nodes/planning/local/simple_local_planner.py#L182-L184
These should not be necessary: https://github.com/AnishShr/autoware_mini_practice/blob/21d92c582d289c5f9fc24b477ca34f7889b10b66/practice_6/nodes/planning/local/simple_local_planner.py#L150-L152
Add from each object closest point to obstacle_distances, its velocity to obstacle_velocities and fill the object_braking_distance depending on the type of object (goal point, or obstacle).
obstacle_distances
obstacle_velocities
object_braking_distance
Here I would convert all to arrays using the same name as you do with the last one (why changing name for the first 2 ones - it makes following all the variables much harder): https://github.com/AnishShr/autoware_mini_practice/blob/21d92c582d289c5f9fc24b477ca34f7889b10b66/practice_6/nodes/planning/local/simple_local_planner.py#L215-L218
So I would like you to simplify the usage of these variable names and it means also some code reorganization. And it all should go a bit simpler.
latest commit: https://github.com/AnishShr/autoware_mini_practice/commit/7d19ddadcd79e106cadf593cf4e87f63427ab2fd
OK
There should be enough of having these: https://github.com/AnishShr/autoware_mini_practice/blob/21d92c582d289c5f9fc24b477ca34f7889b10b66/practice_6/nodes/planning/local/simple_local_planner.py#L182-L184
These should not be necessary: https://github.com/AnishShr/autoware_mini_practice/blob/21d92c582d289c5f9fc24b477ca34f7889b10b66/practice_6/nodes/planning/local/simple_local_planner.py#L150-L152
Add from each object closest point to
obstacle_distances
, its velocity toobstacle_velocities
and fill theobject_braking_distance
depending on the type of object (goal point, or obstacle).Here I would convert all to arrays using the same name as you do with the last one (why changing name for the first 2 ones - it makes following all the variables much harder): https://github.com/AnishShr/autoware_mini_practice/blob/21d92c582d289c5f9fc24b477ca34f7889b10b66/practice_6/nodes/planning/local/simple_local_planner.py#L215-L218
So I would like you to simplify the usage of these variable names and it means also some code reorganization. And it all should go a bit simpler.