Anita77777 / capstone-project

capstone-project-plum.vercel.app
0 stars 0 forks source link

#6 Create Delete Button #11

Open Anita77777 opened 2 years ago

Anita77777 commented 2 years ago

Value Proposition

As a reader I need a delete button to be able to delete book cards.

Description

DeleteButton

Acceptance Criteria

Tasks

Complexity

S

HishamAlmannai commented 2 years ago

Hi Anita,

I am missing the"to be able to" in Value Proposition.

You could add another picture for the Confirmation handling

The Pop-up isn't described enough: one/two buttons? which is selected by default? Does the Button gets deleted or archived in the database?

Maybe you could move some descriptions to the acceptance criteria (see above). Does the Button have a different design? If so add to storybook. It would be more interesting to try to add the pop-up to the storybook. Any testing?

Anita77777 commented 2 years ago

Hi Hisham,

thanks for the remarks. I will not add a pop up after all so that topic is obsolete. Storybook is already added in the Tasks. Testing will be another User Story as I'm waiting for the workshop and then add all the testing for all the components:-)

HishamAlmannai commented 2 years ago

Hi Anita,

Value Proposition is still incomplete.

If you do not want to you a confirmation pop-up in future why implement it?

Anyway approved.