search

Anjaliavv51 / Retro

Explore the vintage look!
https://rococo-mooncake-0d89f7.netlify.app/
MIT License
159 stars 250 forks source link

Made the menu items cards more responsive #558

Open Amrut00 opened 1 month ago

Amrut00 commented 1 month ago

The menu items on the home page were not responsive. I have attached the video demonstrating before and after adding responsiveness to the menu items cards. I have made minor changes in the style.css where in the class menu_items, I added flex-wrap to flexbox, added justify-content to the center, and changed the padding and height of the items. Please review it and suggest any additional requirements.

This is the previous responsiveness of the cards : https://github.com/user-attachments/assets/28a1494f-0b48-4514-bab7-ba2b500a286d

This is the updated responsiveness : https://github.com/user-attachments/assets/31e05680-5d4c-436f-b214-4cd7bf5a5b76

I have committed and pushed my new branch named "make_responsive".

github-actions[bot] commented 1 month ago

Hi there! Thanks for opening this issue @Amrut00!. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

Anjaliavv51 commented 1 month ago

The menu items on the home page were not responsive. I have attached the video demonstrating before and after adding responsiveness to the menu items cards. I have made minor changes in the style.css where in the class menu_items, I added flex-wrap to flexbox, added justify-content to the center, and changed the padding and height of the items. Please review it and suggest any additional requirements.

This is the previous responsiveness of the cards : https://github.com/user-attachments/assets/28a1494f-0b48-4514-bab7-ba2b500a286d

This is the updated responsiveness : https://github.com/user-attachments/assets/31e05680-5d4c-436f-b214-4cd7bf5a5b76

I have committed and pushed my new branch named "make_responsive".

okay , implement go ahead!

Amrut00 commented 1 month ago

I have committed the changes but what to do next?

Anjaliavv51 commented 1 month ago

I have committed the changes but what to do next?

mention the issue numer in PR description the only ur pr will be linked to the issue.

Amrut00 commented 1 month ago

I have updated my pull request description box and added issue no #558. Please review it.

Amrut00 commented 1 month ago

Also please assign me a level if that's ok