sondregronas
commented
2 months ago Just commenting here to say that I've opened a PR to this PR with some more changes - let me know if you want me to switch targets to the main repo. PR: https://github.com/anselor/ankermake-m5-protocol/pull/4
Changes within that PR to this one
- updating
pycryptodomex,flask,flask-sockto the latest version + addingpython-dotenvto dependencies - addresses the change mentioned above in
ankersrv.js - restart the pppp api worker (by calling
worker_start(), which restarts the api state) on pppp failure (see notes below) - start the videoqueue service on
/videoif it isn't running, allowing webrtc access via go2rtc (see #162) - bugfix: allow webserver access with missing credentials (webserver couldn't start without any camera present in cfg)
/api/ankerctl/statusendpoint, displays a JSON of every services state and theapp_api_versiondict
Note regarding pppp:
With this version, pppp should not crash (at least not as often). I've noticed before it would stop working after 2-3 hours of uptime, (but that could also be my really old xeon failing). Instead of crashing it will "flicker" for lack of better words, where sending gcode will sometimes work, and the videostream will have corrupted B/P-frames that only get worse over time. Reloading services are to no avail. Restarting the entire application every 2 hours does circumvent this as far as I can tell.
I tried getting the webserver to run with a different WSGI server, but had no luck. I only tested gevent or eventlet. I wanted to try gunicorn but from my understanding it would require some refactoring to how the cfg is loaded so I stopped trying.
All of these prs combined should resolve (at least to my limited understanding):
163, #161, #158, partially #156 (PPPP will work but stops being reliable), #154, #151, #147, #127 (might be unrelated?), #112
Might be missing a few issues as well that I haven't encountered myself.
Aggregation of many PRs
Integrates the following PRs
123
136
138
145
148
150
155
157
Supersedes #139