search

Ankermgmt / ankermake-m5-protocol

Ankermake M5 protocol specifications and libraries *NOT AFFILIATED WITH ANKER*
GNU General Public License v3.0
161 stars 34 forks source link

Docker improvements #46

Closed billyjbryant closed 1 year ago

billyjbryant commented 1 year ago

Description

Improves a few areas for running as a Docker container:

  1. Adds a CMD statement to the Dockerfile so that unattended docker deployments (such as through Portainer [or any 3rd party Docker manager]) don't automatically fail due to an invalid command.
  2. Changes configHost and configPort to requestHost and requestPort and updates how these values are populated. This now permits displaying the IP address and port of the request in the web interface instead of 0.0.0.0:4470 when using FLASK_HOST=0.0.0.0.

Testing

I tested these changes by building the docker image using Portainer and deploying it to my Synology NAS

Webserver view

image

Print success

image

Container

image

billyjbryant commented 1 year ago

@chrivers I removed pull-policy from the docker compose file.