Closed RisingOrange closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.46%. Comparing base (
6da6afc
) to head (df7a10b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was deployed and Sentry observed the following issues:
957961234.src.lib.sync_hook in create_comparelog
View IssueDid you find this useful? React with a š or š
This PR makes it so that the
AnkiHubImporter
updates note type templates. (It was already adding the view-on-ankihub button and the ankihub end comment before, but now it's updating the whole templates.)Related issues
https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-391
Proposed changes
note_type_with_updated_templates
tomain.utils
: https://github.com/ankipalace/ankihub_addon/blob/df7a10b8dc37c022b06dd974fe75c4a141747e3b/ankihub/main/utils.py#L443-L457main.importing
to update note type templatesComments
We will have another task to make sure that template updates are not applied to AnKing note types if the user has the AnKing note types add-on installed: https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-420 https://github.com/ankipalace/ankihub_addon/pull/970 We should only release the add-on once this task is merged, otherwise users will loose their customizations they made using the AnKing note types add-on.