AnkiHubSoftware / ankihub_addon

1 stars 0 forks source link

[BUILD-391] feat: Update note type templates #969

Closed RisingOrange closed 5 months ago

RisingOrange commented 5 months ago

This PR makes it so that the AnkiHubImporter updates note type templates. (It was already adding the view-on-ankihub button and the ankihub end comment before, but now it's updating the whole templates.)

Related issues

https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-391

Proposed changes

Comments

We will have another task to make sure that template updates are not applied to AnKing note types if the user has the AnKing note types add-on installed: https://ankihub.atlassian.net/jira/software/c/projects/BUILD/boards/1?selectedIssue=BUILD-420 https://github.com/ankipalace/ankihub_addon/pull/970 We should only release the add-on once this task is merged, otherwise users will loose their customizations they made using the AnKing note types add-on.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.46%. Comparing base (6da6afc) to head (df7a10b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #969 +/- ## ========================================== + Coverage 87.42% 87.46% +0.03% ========================================== Files 66 66 Lines 6649 6668 +19 ========================================== + Hits 5813 5832 +19 Misses 836 836 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sentry-io[bot] commented 4 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a šŸ‘ or šŸ‘Ž