AnkitMitraOfficial / StackOverflowClone

StackOverflowClone
MIT License
3 stars 1 forks source link

The `Authentication` directory contains only empty files #12

Open guettli opened 3 years ago

guettli commented 3 years ago

The Authentication directory contains only empty files.

Why it is needed?

AnkitMitraOfficial commented 3 years ago

For all types of Authentication related files

guettli commented 3 years ago

But the files are all empty. This is confusing. If you need them later, then add them later. Code for the current use case, not for the future.

AnkitMitraOfficial commented 3 years ago

I will soon work on the Authentication 👍😊😁

guettli commented 3 years ago

AFAIK this is the most often used auth module for Django: https://github.com/pennersr/django-allauth

I would use this.

AnkitMitraOfficial commented 3 years ago

Well all the django-allauth rests in Authentication

guettli commented 3 years ago

Is this the recommend approach of allauth? If "yes", then please show me the docs.

I pulled just one minute ago and the directory Authentication contains this:

(soclone) guettli@yoga15:~/projects/soclone/src/StackOverFlow-Clone/Authentication$ find| grep -vP '\.pyc|__pycache'
.
./urls.py
./admin.py
./views.py
./tests.py
./apps.py
./templates
./templates/account
./templates/account/email.html
./templates/account/password_reset_from_key_done.html
./templates/account/password_set.html
./templates/account/password_reset.html
./templates/account/base.html
./templates/account/login.html
./templates/account/snippets
./templates/account/snippets/already_logged_in.html
./templates/account/email_confirm.html
./templates/account/password_reset_from_key.html
./templates/account/verification_sent.html
./templates/account/email
./templates/account/email/email_confirmation_message.txt
./templates/account/email/base_message.txt
./templates/account/email/password_reset_key_subject.txt
./templates/account/email/email_confirmation_signup_message.txt
./templates/account/email/email_confirmation_signup_subject.txt
./templates/account/email/password_reset_key_message.txt
./templates/account/email/email_confirmation_subject.txt
./templates/account/account_inactive.html
./templates/account/logout.html
./templates/account/password_reset_done.html
./templates/account/signup_closed.html
./templates/account/verified_email_required.html
./templates/account/messages
./templates/account/messages/cannot_delete_primary_email.txt
./templates/account/messages/logged_out.txt
./templates/account/messages/password_changed.txt
./templates/account/messages/password_set.txt
./templates/account/messages/email_confirmed.txt
./templates/account/messages/unverified_primary_email.txt
./templates/account/messages/primary_email_set.txt
./templates/account/messages/email_deleted.txt
./templates/account/messages/email_confirmation_sent.txt
./templates/account/messages/logged_in.txt
./templates/account/password_change.html
./templates/account/signup.html
./models.py
./__init__.py
./migrations
./migrations/__init__.py

Only the directory ./templates/account has meaningful content. Why not move it to HomeSite?

Related #18

AnkitMitraOfficial commented 3 years ago

Okay :+1: