search

Ankithukral / oopms

Automatically exported from code.google.com/p/oopms
0 stars 0 forks source link

[RequirementPortlet][ReviewCode] Code of Controllers are not good #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
RequirementPortlet, rev 774

- Class RequirementController
 + Try..catch but no processing error
Ex: , codes 165 ~ 180

 + No logging for exception
Line 247. Using logging instead of ex.printStackTrace();
Line 244, 249:
 + "messages.properties" is loaded manually => what's the purpose?
 + requirementError is not used

=> Please assign other team members to peer review source code of all Portlets.

Original issue reported on code.google.com by thachln@gmail.com on 19 Aug 2012 at 3:05

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by duynd...@gmail.com on 19 Aug 2012 at 12:59