AnkouOSRS / unpotted-reminder

A plugin that reminds you to drink your boost potions
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Keeps on saying I need to repot #13

Closed Whisperhelp closed 1 month ago

Whisperhelp commented 7 months ago

I turned lvl 80 and the plugin is broken now. I reinstalled runelit and uninstalled the plugin and reset the config but it keeps on going off over and over. help!

Whisperhelp commented 7 months ago

I am notified to drink potion over and over again even right after drinking. this happens when attack giant spiders in stronghold of security.

AnkouOSRS commented 7 months ago

Any chance you've set your boost threshold for ranged beyond what the potion actually boosts you in the plugin settings?

On Tue, Jan 16, 2024, 11:48 PM Whisperhelp @.***> wrote:

I am notified to drink potion over and over again even right after drinking. this happens when attack giant spiders in stronghold of security.

— Reply to this email directly, view it on GitHub https://github.com/AnkouOSRS/unpotted-reminder/issues/13#issuecomment-1894933897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHO53277LLOJLAKKQZIFTYO5JYLAVCNFSM6AAAAABB53SHN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUHEZTGOBZG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Whisperhelp commented 7 months ago

Nope. This is very strange. as soon as i turned lvl 80 this happened. here are pics and stats. I even have ranged turned off. This only happens when I go into combat with the monsters I am currently fighting but never had this problem in this same situation before lvl 80.

Capture33 Capture333

Whisperhelp commented 7 months ago

I can confirm on a different PC with runelit and a new plugin profile that the problem persists.

AnkouOSRS commented 7 months ago

Weird! Thanks for the details I'll take a look when I get a chance but please be patient.

On Wed, Jan 17, 2024, 3:49 PM Whisperhelp @.***> wrote:

I can confirm on a different PC with runelit and a new plugin profile that the problem persists.

— Reply to this email directly, view it on GitHub https://github.com/AnkouOSRS/unpotted-reminder/issues/13#issuecomment-1896665390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHO52PY5YWFFXW4ELD3LDYPA2OZAVCNFSM6AAAAABB53SHN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGY3DKMZZGA . You are receiving this because you commented.Message ID: @.***>

Whisperhelp commented 7 months ago

Weird! Thanks for the details I'll take a look when I get a chance but please be patient. On Wed, Jan 17, 2024, 3:49 PM Whisperhelp @.> wrote: I can confirm on a different PC with runelit and a new plugin profile that the problem persists. — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHO52PY5YWFFXW4ELD3LDYPA2OZAVCNFSM6AAAAABB53SHN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGY3DKMZZGA . You are receiving this because you commented.Message ID: @.>

Yeah you got it! and no worries I will stand by. I wonder if another plugin could be messing with it? However, I don't know how it all works.

AnkouOSRS commented 7 months ago

Actually after taking a look at your screenshot I know what's happening here. You're training attack so the plugin checks your attack boost, which for you is 0 since you're only boosting strength. If you were training strength or boosting attack this wouldn't happen.

I do admit this is pretty confusing behavior and I've been considering improving how melee works so that would fix your issue but I'd have to think about how to implement that

AnkouOSRS commented 7 months ago

Probably best for me to add an option to have it only check strength for melee if that's what people prefer

Whisperhelp commented 7 months ago

I believe if you code it so it only looks at strength it should fix the problem or give an option for it to only focus on one stat or multiples at a time.On Jan 17, 2024, at 7:46 PM, Ankou @.***> wrote: Probably best for me to add an option to have it only check strength for melee if that's what people prefer

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

nickrs123 commented 3 months ago

@AnkouOSRS i just posted, but it seems like similar issue is happening here. i am training attack but only using super strength potion. any way to add a checkbox to choose whether it focuses on attack, strength, or defense?

your plugin is amazing just hope i can still use it without having to use scbs