AnkouOSRS / unpotted-reminder

A plugin that reminds you to drink your boost potions
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Doesn't seem to work on my client #2

Closed cloud-aspect closed 1 year ago

cloud-aspect commented 1 year ago

The plugin doesn't seem to work, which is a shame because I think it would be really useful.

Is there some way I can help you test it and troubleshoot the issue on my end?

What I'm doing: set melee threshold to 12, drink super def, atk, str pots, I start at +17 and while in combat allow the stat to drain to the point where the boost is only +11, nothing happens

Have I misunderstood how its suppose to work?

Attaching an image with my plugin settings

image

AnkouOSRS commented 1 year ago

I think this issue might be because of the "Xp Threshold" setting. To be completely honest with you, I think I set the description to say 0 to disable but never actually included the logic for that. My bad!

Try with a higher threshold for that as it is currently ignoring any xp drops above that number.

AnkouOSRS commented 1 year ago

Actually, I did add the logic for disabling that at 0. The real issue here is I didn't add support for super attack/str which I really should have. For melee I only added divine and regular super combats for the initial plugin release. I'll add the rest soon.

cloud-aspect commented 1 year ago

Thank you very much! Probably should add support for all combat boosting potions too, even the lesser ones

AnkouOSRS commented 1 year ago

Agreed. I went ahead and added regular combat, attack, and strength, as well as divine and regular super attack and strength. As soon as someone on the Runelite side approves it the plugin should work for you after updating. If not feel free to open another issue. Thanks for pointing this out.