AnnMarieW / dash-app-gallery

Dash Examples Index
https://dash-example-index.herokuapp.com/
MIT License
64 stars 25 forks source link

Added eu-indicators via new fork #134

Closed tuopouk closed 4 months ago

tuopouk commented 1 year ago

@Coding-with-Adam Here's new commit from a new fork. Please check if this works.

Coding-with-Adam commented 1 year ago

Thank you @tuopouk Now this app can be merged with no conflicts. I appreciate you re-forking the repo and adding the helpful comments inside the app file.

This app is a nice example of a clientside callback and a chained callback.

@AnnMarieW do you have any suggestions for this app to simplify it even more?

Coding-with-Adam commented 1 year ago

@tuopouk Don't mind the numerous commits. I made a small mistake updating all the callbacks when I really just wanted to update clientside_callback, based on Ann's suggestions to me. (it needs to be dash.clientside_callback rather than app.clientside_callback, just like you did with your Finland app.)

I also created a csv file from the download link and put it on the plotly dataset repo. I like your headers example, showing people how to read a file from a url, but I'm worried that the download link won't work in the future and the app will break. So for longevity purposes I put the file on Plotly's github.

Ann suggested we do a forum post to show the original version and explain how to get data like that into a dash app. Then we could link to that post in the Example App Index. I like that idea and will try to implement this later today.

Are you ok with all this?

tuopouk commented 1 year ago

@Coding-with-Adam Sorry, I thought I replied it's ok for a while ago. 😆 Yeah, it's ok, if you can merge still 👍

AnnMarieW commented 4 months ago

@tuopouk I know this is ancient history, but I was just doing some clean-up and found this app. I totally missed it previously -- I'm so sorry! I thought it was a duplicate of one that was merged previously: https://dash-example-index.herokuapp.com/key-figures-finland

I'm merging this now and it will be live with the next batch of apps in the next week or two.

Nice app! and thanks so much for this contribution.

tuopouk commented 4 months ago

@AnnMarieW No worries. Thanks for replying, I appreciate it!