AnnMarieW / dash-app-gallery

Dash Examples Index
https://dash-example-index.herokuapp.com/
MIT License
59 stars 24 forks source link

created clipboard example app #138

Closed jennalenoble closed 1 year ago

jennalenoble commented 1 year ago

This app uses Clipboard component to copy a csv dataset. It also includes Loading component and a scatter plot that has the ability to change the x variable with RadioItems.

AnnMarieW commented 1 year ago

Hey @jennalenoble Thanks for this excellent example :rocket:

You have a lot of great content in a minimal example. Nice use of a table, figure and the Clipboard RadioItems components.

Including the dcc.Loading() is nice too. However, since this callback is so fast, the loading animation doesn't show up - it just makes the figure flash when you use the radio buttons to update the figure. Two possible solutions -- either remove dcc.Loading() or add a add a delay in the callback - something like:

    time.sleep(2) # simulate longer callback 
    return fig

It might be good to take the dcc.Loading out of this example and create another example to demo dcc.Loading component. @Coding-with-Adam - what do you think?

The code looks great! The only change I see so far is the code formatting with Back . You can add that to this PR, or we'll just do that after it's merged.

Coding-with-Adam commented 1 year ago

It might be good to take the dcc.Loading out of this example and create another example to demo dcc.Loading component. @Coding-with-Adam - what do you think?

Good job @jennalenoble . Agreed, we can take out dcc.Loading from this example.

jennalenoble commented 1 year ago

Thanks so much for the feedback @AnnMarieW & @Coding-with-Adam! The recent commit incorporates the code changes and uses Black formatting in both files.

Coding-with-Adam commented 1 year ago

Thanks @jennalenoble .

@AnnMarieW can I merge this app or do you prefer to take one last look?

jennalenoble commented 1 year ago

Just made one more commit to remove the loading documentation from the pages file since I removed the loading component from the app.

AnnMarieW commented 1 year ago

Both apps look good to me! :woman_dancing: