fix parsing of boostrap prop names

AnnMarieW / dash-bootstrap-templates

A collection of 52 Plotly figure templates with a Bootstrap theme. Two theme switch components. Stylesheet to apply Bootstrap themes to Plotly Dash components.

https://hellodash.pythonanywhere.com/

MIT License

135 stars 25 forks source link

fix parsing of boostrap prop names #22

Closed oliverb closed 1 year ago

oliverb commented 1 year ago

Noticed a small bug when trying to apply your code to our in-house Bootstrap template.

Currently, lstrip("--bs-") does not strip the exact string but all matching characters from the left. Thus --bs-secondary is parsed to econdary and will never match the lookup for desired role colors. On our end I simply resorted to stripping the appropriate number of characters from the left.

Cheers Oliver

AnnMarieW commented 1 year ago

Hi @oliverb

Nice catch - thanks! :pray:

It looks like this will just make a slight adjustment to the shade of green (success) color in the colorways. I think it's subtle enough that it shouldn't be considered a breaking change. After this is merged, I'll release it as patch 1.1.1