search

Anndrey24 / VLC_Speed_Controller

Speed Controller Extension for VLC Media Player
GNU General Public License v3.0
10 stars 4 forks source link

A few suggestions #2

Closed xan2622 closed 2 years ago

xan2622 commented 2 years ago

Hi Andrei. First, thank you for making this very convenient add-on. 👍 I have been looking for such add-on for a long time.

I have made a "mock-up image" to illustrate some UI changes I'd like to see in version 1.2 (if you agree with them of course):

9a09

  1. Move - and + buttons on the same line as "Speed:"

  2. Align the speed value to the right (in the white input box)

  3. Add 6 small buttons with custom speed values (the user would be able to modify these values in the Settings):

429ac7145(1)

  1. Add a "Settings" button on the bottom right corner

Thank you in advance for considering to add these changes.

Anndrey24 commented 2 years ago

Wow, thank you very much for the detailed suggestions! I'll be the first to admit that designing UI isn't my strong suit, so I'll gladly implement your ideas as soon as possible.

xan2622 commented 2 years ago

Seeing my mock-up makes me think that maybe the "Preferred" button is no longer needed. After all, if the user can set custom speeds on these 6 buttons, there's a high chance that among all these buttons is the user's preferred speed. That's why I think the "Preferred" button will become useless.

My new mock-up image (now showing 8 custom speeds buttons):

4a37b71

Anndrey24 commented 2 years ago

I added the custom speed buttons and everything seems to be functioning well. However, even after searching everywhere, I wasn't able to find a way to make the default size of the buttons any smaller, so we are stuck with this stretched design unfortunately. The number in the text box can't be aligned to the right either. The widget manager seems to be very basic in this regard, not really allowing any customization, but at least the proposed functionality is implemented now.

xan2622 commented 2 years ago

Thank you for this update!

About the lack of customization for the buttons width: it's unfortunate. Maybe that is something that should be reported to the VLC developers (hopefully they can allow to change buttons width).

Anndrey24 commented 2 years ago

It's definitely something that I hope is added for VLC 4. In the meantime, I guess we'll work with what we have. This entire add-on will need to be rebuilt from the ground up once VLC 4 is officially released anyways.

Thanks again for the suggestion!