search

AnneTrue / nexus-clash-interface-tweaks

A userscript that tweaks the Nexus Clash user interface to be bearable
MIT License
5 stars 4 forks source link

Improve createSettingsPane #19

Closed Argavyon closed 2 years ago

Argavyon commented 2 years ago

todo: get elems async, add to row sync is now done

AnneTrue commented 2 years ago

Thanks for all the PRs! I'll try to get through them all as I have time, and I'll start with this one as it's the smallest. I think this TODO is left over from when I originally rewrote the scaffolding some 4-ish years ago.

I would prefer to simply delete the TODO comment and leave the code as-is.

Making it asynchronous does not improve the performance in any way. However, making it async does make the code more dense and inaccessible to non-JS developers. There's already enough syntactic sugar and cleverisms that I regret in the codebase. :(

Argavyon commented 2 years ago

Thanks for all the PRs! I'll try to get through them all as I have time, and I'll start with this one as it's the smallest. I think this TODO is left over from when I originally rewrote the scaffolding some 4-ish years ago.

I would prefer to simply delete the TODO comment and leave the code as-is.

Making it asynchronous does not improve the performance in any way. However, making it async does make the code more dense and inaccessible to non-JS developers. There's already enough syntactic sugar and cleverisms that I regret in the codebase. :(

Fair