AnnesFlashBack / Mini-Exercises

Anne Gregersen's repository containing the MiniExercises for AP 2018.
0 stars 0 forks source link

Feedback on mini_ex_8 by Sille Nygaard Kock #17

Open SilleKock opened 6 years ago

SilleKock commented 6 years ago

Hi Anne,

The program is based on data from GIPHY. You have made an input field where the user can type in something and when hitting the search button GIFs related to the search word will appear. The user can adjust the amount of GIFs showing by using the slider (1-100). The program basically works as a search engine.

What I was really impressed with in your work is the way you have worked with the layout - very well done! It is nice to see something 'designed' instead of the basic black/white buttons. I don't really know how you did this, but it looks good :-) Your code is very well written with a lot of comments to make it a little easier to understand - this worked out well for me, since this code is way more advanced than what I can do. Therefore, I don't think I'm in the position to give you feedback on the code.

From reading your README file I can understand that you chose to do something simple due to the fact that APIs can be challenging. I think you did a really good job in terms of making the program simple but also applying a lot of other complicated things such as the way you worked with the styling of the program.

Nice work!