search

Annex-Engineering / klipper_estimator

MIT License
268 stars 27 forks source link

Support floats for M73 P #28

Closed garethky closed 1 year ago

garethky commented 1 year ago

M73 commands seem to be overwritten by the script but they are always integers. When the print is long, each 1% represents a large chunk of time. klipper supports float values for the M73 P parameter which would give a more granular estimate update for long running prints.

I think here you just want to get rid of that call to round() or round it to say 3 decimal places.

garethky commented 1 year ago

PR: https://github.com/Annex-Engineering/klipper_estimator/pull/29

garethky commented 1 year ago

Bit of an update after testing: Neither Fluidd nor KlipperScreen use the percentage reported by the M73 command. In my testing you cant update the display at all via M73. The slicer time is correct but its just a countdown. The % is wildly off. E.g. Slicer M73 says 37%, display says 25%. This is out of agreement with the reported time/total time. I guess they were previously justified in doing this as the % was not that useful or accurate before this.