search

AnnieShi / dsn1674-assignment-2

Practicing what we learned in class to create a webpage
0 stars 0 forks source link

Can't seem to get my links to work #3

Open AnnieShi opened 9 years ago

AnnieShi commented 9 years ago

Hi, I looked over your examples of links and tried to follow them as best I can, but they won't appear in my browser when I check. Also is . the correct way to deal with that info? Thanks, Annie @thomasjbradley

thomasjbradley commented 9 years ago

Question 1:

There's two problems I can see with your links, here are the lines I'm referring to: https://github.com/AnnieShi/dsn1674-assignment-2/blob/gh-pages/index.html#L91-L92

  1. The closing quote for the href="" attribute is missing, immediately after the words Mars & Venus
  2. There's no content to show on the screen to users: between the open <a> and close </a> tags there should be something written to show to users. If you look right here, in my example, if may become a little more clear: https://github.com/algonquindesign/html-css/blob/gh-pages/html-semantics/links.html#L9

Question 2:

For the orbital period, it makes sense to use the <time> element, so the markup would look something like this:

<time datetime="P224.7D">224.7 Earth days</time>

Here's the detailed documentation on what goes inside the datetime attribute: https://en.wikipedia.org/wiki/ISO_8601