Annosz / UIInfoSuite2

Ongoing maintenance for the original UI Info Suite mod for Stardew Valley.
1.47k stars 272 forks source link

Compatibility with Ridgeside Village #168

Open Yeon128 opened 2 years ago

Yeon128 commented 2 years ago

I was just wondering if it was possible to get the NPC map tracking to work with Ridgeside Village.

All of the NPCs in RidgeSide show up in the top corner until they come to Pelican Town. And when I open the Ridgeside map, the Ridgeside NPCs are displayed overlapping the NPCs in Pelican Town.

After installing a new version of both modes today, I couldn't open the Ridgeside map until I visited Ridgeside. In the past, there was a separate rectangular ridge map on the left side of the map, so I could press it to open it, but it disappeared after this update.

I'm not sure which problem it is, so I'm asking both sides.

Annosz commented 2 years ago

Hi! Can you please provide a link to the place where you raised this issue (either Nexus or GitHub) for RidgeSide mod?

Yeon128 commented 2 years ago

Hi! Sorry for the late reply. Unfortunately, I have not received an answer yet, although I asked the Posts of Ridge Side in Nexus on the same day on 24 April 2022. I just looked it up and found my inquiry on page 4 of the link.

https://www.nexusmods.com/stardewvalley/mods/7286?tab=posts&BH=8

Yeon128 commented 2 years ago

I've been playing with the new version of Rideside these days, and the map is back!

On the left outside the existing map screen, I will see the same small Rideside map again, and if I click on the map, I can zoom in on the Pelican Town map and see it larger. (Oh, there's a possibility that I haven't seen it before.)

However, as only the location of the reduced map has changed, it is still the same as before, so when the map is unfolded, the NPCs of Pelican Town overlap on the map.

Yeon128 commented 2 years ago

I asked Ridgeside of Nexus again just in case, and I'll let you know when I get an answer. I also attach a picture of the overlapping problem of tracked NPCs on the two maps. (When I open the Ridgeside map, the rest of the NPCs except me are duplicated in the Ridgeside map.) 20220526144258_1

cl4r3 commented 2 years ago

Hello! I'm the current maintainer of RSV, and I came here after replying to Yeon128's comment on our Nexus page. I was looking for a way to contact you - As I explained to Yeon128, when it came to another mod that adds NPC icons to the map, Bouhm's NPC Locations, we had to ask the custom NPC component maintainer Yagisan to disable the mod for Ridgeside Village's locations so that our custom map could work alone. So I came here to see if you could do the same, rather than us having to patch your code to do it ourselves, which could be messy (but doable if necessary). Feel free to DM me if you'd like to discuss this further.

Annosz commented 2 years ago

Hi @cl4r3! Thank you for the explanation! :) I will look into how Bouhm's NPC Locations handles it, if it's not a complicated thing, I will implement it too. But I already has a check in UI Info Suite which disables the map tracking features if the NPC Locations is installed, because they implemented the multiplayer maps better, so they have precedence - it is possible that in the end I will just recommend that mod for Ridgeside village as well. Can you tell me when did they implemented this feature? Will be easier to find their changes.

cl4r3 commented 2 years ago

Sure thing - So the main mod, Custom NPC Locations by Bouhm, explains how mod authors can add location exclusions here. The actual implementation is kind of spread around the ModEntry file, but in short, after getting any exclusion locations added by content packs, the actual exclusion from the minimap is done here. Yagisan then created a content pack using Content Patcher to handle the location exclusions for Ridgeside - That code can be found here. I hope this helps! Please let me know if there's anything else I can do.

Yeon128 commented 2 years ago

Thank you for your generous help! I'm worried if I'm bothering you. I sent you a cup of coffee, so cheer up while drinking! If you need my help, please feel free to ask for it :)