Annoto / moodle-filter_annoto

Annoto Moodle Filter plugin
GNU General Public License v3.0
0 stars 0 forks source link

Incorrect camel case. #4

Open danmarsden opened 5 years ago

danmarsden commented 5 years ago

Moodle uses sentence case - strings like: $string['setupheading'] = 'Annoto Setup'; $string['appsetingsheading'] = 'Annoto Settings'; $string['cta'] = 'Call To Action';

Should be: $string['setupheading'] = 'Annoto setup'; $string['appsetingsheading'] = 'Annoto settings'; $string['cta'] = 'Call to action';

Please review all your lang strings.

danmarsden commented 5 years ago

Also: $string['filtername'] = 'Filter Annoto'; $string['pluginname'] = 'Filter Annoto';

Should really be something like: $string['filtername'] = 'Annoto'; $string['pluginname'] = 'Annoto';

Or maybe something like: $string['filtername'] = 'Annoto social video'; $string['pluginname'] = 'Annoto social video';

The main point is that the word "filter" shouldn't really be part of the pluginname (see other moodle filters for examples)