AnnsAnns / sphene

Fixes the extremely annoying Twitter, Bluesky, Instagram & Twitter embed bug on Discord
https://discord.com/api/oauth2/authorize?client_id=1134171949338214491&permissions=292057802816&scope=bot
European Union Public License 1.2
3 stars 2 forks source link

Non post embed triggering & Special character removed when change embed options #36

Open surya27895 opened 2 months ago

surya27895 commented 2 months ago

I don't know how to describe this since my english not quite good but I will try my best

Hope this can fix soon, thanks for your hard works :)

AnnsAnns commented 2 months ago

Non Post Embed Triggering

This one is hard for me to fix, esp. with Instagram since I don't actually use Instagram or Twitter. In the case of Twitter it might be easy to do though. I'll look into it when I have the time.

Special Characters Removed

I haven't experienced this myself and the code shouldn't ever do this. I'm not sure how to replicate it, sorry :(

surya27895 commented 1 month ago

finally i get the link with special characters, here for the context

https://github.com/AnnsAnns/sphene/assets/22859567/7dba6dfc-ed61-4492-b96d-410af2eecfd6

here the post link https://www.instagram.com/reel/C7GfxTTvX_-/

This one is hard for me to fix, esp. with Instagram since I don't actually use Instagram or Twitter. In the case of Twitter it might be easy to do though. I'll look into it when I have the time.

for the instagram, I think them has only 4 types of link which structure

so it can be done with excepting trigger if link not contain /p/ /reel/ or /stories/, but i don't know how is from coder perspective can be done easily or not