Closed cnuss closed 7 months ago
cc @jayair could i get some 👀 on this please? thank you!
cc @warrickhill this is a similar fix to https://github.com/AnomalyInnovations/serverless-bundle/pull/354 but includes tests 😄, which I didn't actually see your pre-existing PR until after I did this work.
Ok I tweaked this a bit so that the "default config" doesn't hardcode aws-sdk. It's now programatically added in the event the runtime is less than nodejs18.x
, which should be more future proof!
We currently use our own fork of serverless-bundle because of this. Good work, hope this gets merged!
Thank you for this (and adding the tests)!
On
nodejs18.x
and greater,aws-sdk
is no longer included and should be conditionally excluded based on theruntime
version, instead of being a hardcoded exclude.Fixes:
Ref: https://stackoverflow.com/a/74792625