Open sean9keenan opened 6 years ago
@sean9keenan Nice work! This is something we should add to the tutorial. Did you find any documentation for this on AWS' side? We'd want to link to that in the tutorial as well.
@sean9keenan Great! Thanks. I'll take a look and figure out how to integrate it with the tutorial.
thx @sean9keenan
@sean9keenan I added a section in the Deploy chapter on your PR and linked to it as well - https://serverless-stack.com/chapters/deploy-to-s3.html#app-bundle-size
Thanks again.
Pulled out the S3 dependency, and imported AWS directly from aws-sdk/global.
This makes it possible for webpack to minimize the AWS SDK as the other dependencies don't even enter the picture.
The net impact for me was reducing the javascript file that is downloaded from 1.9MB to 788KB, which was a pretty big win in my book! (Specifically the
aws-sdk
is now 216KB vs 1.3MB)Although I'll be honest - it took me longer than I care to admit to find this particular incantation to reduce the bundle size... š
For future people that might read this:
import { Config, CognitoIdentityCredentials } from 'aws-sdk'
. Completely works - you just have to pass theConfig
manually into the second arg ofCognitoIdentityCredentials
, as well as change the region on the config directly as a property, but alas this doesn't let Webpack minimize the sdk properly.