AnomalyInnovations / serverless-stack-demo-client

Source for the demo app client in the Serverless Stack Guide
https://demo2.serverless-stack.com
MIT License
635 stars 204 forks source link

Changed import of AWS - reduce code size #15

Open sean9keenan opened 6 years ago

sean9keenan commented 6 years ago

Pulled out the S3 dependency, and imported AWS directly from aws-sdk/global.

This makes it possible for webpack to minimize the AWS SDK as the other dependencies don't even enter the picture.

The net impact for me was reducing the javascript file that is downloaded from 1.9MB to 788KB, which was a pretty big win in my book! (Specifically the aws-sdk is now 216KB vs 1.3MB)

Although I'll be honest - it took me longer than I care to admit to find this particular incantation to reduce the bundle size... šŸ˜„

For future people that might read this:

jayair commented 6 years ago

@sean9keenan Nice work! This is something we should add to the tutorial. Did you find any documentation for this on AWS' side? We'd want to link to that in the tutorial as well.

sean9keenan commented 6 years ago

Yup! This link is the best - but it doesn't talk about the global import

This is the original git issue

And this is the tutorial where I found the pointer for the global import - which also has a part one

jayair commented 6 years ago

@sean9keenan Great! Thanks. I'll take a look and figure out how to integrate it with the tutorial.

quantuminformation commented 6 years ago

thx @sean9keenan

jayair commented 6 years ago

@sean9keenan I added a section in the Deploy chapter on your PR and linked to it as well - https://serverless-stack.com/chapters/deploy-to-s3.html#app-bundle-size

Thanks again.