search

AnomalyInnovations / serverless-stack-demo-client

Source for the demo app client in the Serverless Stack Guide
https://demo2.serverless-stack.com
MIT License
635 stars 204 forks source link

Login.js Ln 58 #23

Open walshe opened 6 years ago

walshe commented 6 years ago

how come this line is missing 0 as mentioned in the tutorial

this.props.history.push("/");

jayair commented 6 years ago

@walshe Which line are you talking about in which part of the tutorial? Line 58 in Login.js is this one https://github.com/AnomalyInnovations/serverless-stack-demo-client/blob/master/src/containers/Login.js#L58.

walshe commented 6 years ago

yes line 58 in Login.js .. where has the this.props.history.push("/"); right after the user has been marked as authenticated?

jayair commented 6 years ago

@walshe I'm sorry I don't understand what you are saying. Can you elaborate?

walshe commented 6 years ago

what I am trying to say is this:

this line is missing in Login.js: this.props.history.push("/")

jayair commented 6 years ago

@walshe No we don't need that line after we secure our pages. It's in this chapter - https://serverless-stack.com/chapters/redirect-on-login.html

walshe commented 6 years ago

ah I see :)

Btw, another question.. doesnt Cognito have some way of easily integrating default (but customizable) signup/login forms that be used in a web app (similar to auth0) so that a developer does not have to go to the trouble ? and if so would it be nice to add to the tutorial @jayair